-
-
Notifications
You must be signed in to change notification settings - Fork 296
feat(plugins): remember last-used export and import settings #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // | ||
| // PluginSettingsSnapshot.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
| import TableProPluginKit | ||
|
|
||
| struct PluginSettingsSnapshot { | ||
| private var entries: [(plugin: any SettablePluginDiscoverable, data: Data)] | ||
|
|
||
| init(plugins: [any SettablePluginDiscoverable]) { | ||
| entries = plugins.compactMap { plugin in | ||
| guard let data = plugin.snapshotSettingsData() else { return nil } | ||
| return (plugin, data) | ||
| } | ||
| } | ||
|
|
||
| func restore() { | ||
| for entry in entries { | ||
| entry.plugin.restoreSettingsData(entry.data) | ||
| } | ||
| } | ||
|
|
||
| mutating func recapture(_ plugin: any SettablePluginDiscoverable) { | ||
| guard let index = entries.firstIndex(where: { $0.plugin === plugin }), | ||
| let data = plugin.snapshotSettingsData() else { return } | ||
| entries[index].data = data | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // | ||
| // TransferDialogStorage.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| final class TransferDialogStorage { | ||
| static let shared = TransferDialogStorage() | ||
|
|
||
| private let defaults: UserDefaults | ||
|
|
||
| private enum Keys { | ||
| static let lastExportFormatId = "com.TablePro.export.dialog.lastFormatId" | ||
| static let lastImportEncoding = "com.TablePro.import.dialog.lastEncoding" | ||
| } | ||
|
|
||
| init(userDefaults: UserDefaults = .standard) { | ||
| self.defaults = userDefaults | ||
| } | ||
|
|
||
| func loadLastExportFormatId() -> String? { | ||
| defaults.string(forKey: Keys.lastExportFormatId) | ||
| } | ||
|
|
||
| func saveLastExportFormatId(_ formatId: String) { | ||
| defaults.set(formatId, forKey: Keys.lastExportFormatId) | ||
| } | ||
|
|
||
| func loadLastImportEncoding() -> ImportEncoding { | ||
| guard let rawValue = defaults.string(forKey: Keys.lastImportEncoding), | ||
| let encoding = ImportEncoding(rawValue: rawValue) else { | ||
| return .utf8 | ||
| } | ||
| return encoding | ||
| } | ||
|
|
||
| func saveLastImportEncoding(_ encoding: ImportEncoding) { | ||
| defaults.set(encoding.rawValue, forKey: Keys.lastImportEncoding) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these requirements changes the
SettablePluginDiscoverablewitness table that export/import plugins compiled against kit 18 provide, butPluginManager.currentPluginKitVersionand the bundledInfo.plistkit declarations still remain at 18. In an installation with an existing third-party settable export/import plugin built against the previous kit 18, version validation will still accept and load it, and the new dialog paths callsnapshotSettingsData/resetSettingsToDefaultsthrough this existential, which can dispatch against a stale witness table instead of forcing the plugin to rebuild against the new protocol. Please bump the plugin kit version and bundled plugin declarations so incompatible plugins are rejected or updated.Useful? React with 👍 / 👎.