fix(import): make JSONImportPluginTests link#1545
Conversation
…ng into a shared file (#1536)
There was a problem hiding this comment.
💡 Codex Review
TablePro/TablePro.xcodeproj/project.pbxproj
Line 504 in 549a36f
When building TableProTests, this synchronized-folder setting does not make JSONImportParsing.swift available to the test target: membershipExceptions are the files excluded from the target (the existing plugin entries use the same field to exclude Info.plist). Since the tests now reference JSONImportParsing directly and no longer import JSONImport, the test target will fail to compile with Cannot find 'JSONImportParsing' in scope unless this source file is actually added as a target member.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes the pre-existing
macOS App Testsfailure on main (introduced with #1536 and merged red).Problem
JSONImportPluginTestsdid@testable import JSONImportand called the plugin's static methods.JSONImportbuilds as a loadable.tableplugin(wrapper.cfbundle), whose symbols a test target cannot link, so everyJSONImportPlugin.*reference was an undefined symbol at link time andmacOS App Testsfailed. No other plugin test imports a plugin module this way.Fix
JSONImportParsing(a plain enum, no SwiftUI or bundle surface).JSONImportPlugindelegates to it; behavior unchanged.JSONImportParsing.*and drops@testable import JSONImport.membershipExceptionsset compilesJSONImportParsing.swiftintoTableProTeststoo (same mechanismmcp-serveruses to shareTablePro/sources), so the test links its own copy instead of the loadable bundle.Verification
xcodebuild test -only-testing:TableProTests/JSONImportPluginTestspasses locally (previously failed to link). All assertions unchanged.