Skip to content

fix(hig): rebuild the key view loop so Tab crosses window panes (#1490) #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 2 commits into from
May 30, 2026
Merged

fix(hig): rebuild the key view loop so Tab crosses window panes (#1490) #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7906464
fix(hig): rebuild the key view loop so Tab crosses window panes (#1490)
datlechin May 30, 2026
6ad9e3e
Merge branch 'main' into a11y/tab-between-panes
datlechin May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Tab moves keyboard focus between the window panes (sidebar, results, inspector) by rebuilding the key view loop when the window appears. (#1490)
- The license activation sheet focuses the key field on open, the SQL review sheet closes with Escape even while the editor has focus, and the integration token sheet focuses its Done button. (#1490)
- Copy with Headers now has a default keyboard shortcut (Cmd+Option+C), so it works and is discoverable from the keyboard instead of showing in the Edit menu with no key. (#1490)
- VoiceOver now reads the column name and current value for each field editor in the cell inspector. (#1490)
Expand Down
1 change: 1 addition & 0 deletions TablePro/Core/Services/Infrastructure/MainSplitViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ internal final class MainSplitViewController: NSSplitViewController, InspectorVi

installObservers()
recomputeWindowMinSize()
window.recalculateKeyViewLoop()

@chatgpt-codex-connector chatgpt-codex-connector Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Recalculate the loop after materializing the inspector

When the inspector is hidden on launch, this marks the key-view loop dirty before the inspector pane contains its real controls (viewDidLoad installs Color.clear until showInspector() calls materializeInspectorIfNeeded()). If the user tabs anywhere before opening the inspector, AppKit will rebuild the loop without those inspector views; later showInspector() swaps in the inspector and expands the split item without another recalculateKeyViewLoop(), so Tab still cannot reach the inspector pane. Consider recalculating after materializing/showing panes as well as on initial appearance.

Useful? React with 👍 / 👎.

}

override func viewDidDisappear() {
Expand Down
Loading