test(connections): cover the delete persist-before-notify sync invariant

[datlechin]

Summary

Phase 8 / R-008: make the documented sync invariant executable. CLAUDE.md records that SyncChangeTracker.markDeleted() must run after saveConnections() — persist before notify, or a sync can re-upload a just-deleted record. ConnectionStorage.deleteConnection implements this (persist behind a guard, then markDeleted for non-local/non-sample connections), but it had no test.

Adds two regression tests against a real ConnectionStorage wired to a test-backed SyncChangeTracker/SyncMetadataStorage and a temp file:

• Deleting a connection records a sync tombstone after it is persisted.
• A delete that fails to persist (storage directory removed to force the saveConnections write to fail) records no tombstone — pinning the persist-before-notify guard.

Risk Addressed

• R-008: sync invariants were documented but not enforced by tests; a regression in the delete ordering could silently re-upload deleted records across devices.

Verification

• xcodebuild test -only-testing:TableProTests/ConnectionStorageSyncDeleteTests — both tests pass.
• Test target builds.

Notes

• Test-only change; no production code touched. No CHANGELOG / ABI / docs.
• UserDefaults(suiteName:)! matches the existing storage-test convention (force_unwrapping is warning-level).
• Scope note: the broader R-008 sync consolidation (shared record/conflict types in TableProSync, desktop adopting them) is blocked behind the same PluginKit single-module work as the desktop DatabaseType adoption, and is tracked separately.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12436eabbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Use a per-test temp directory before deleting it

When the Swift Testing runner executes storage tests concurrently, this removes the shared temporaryDirectory/tablepro-tests directory rather than only this test's fixture, because storageDirectory is just fileURL.deletingLastPathComponent(). Other tests in the repo create their own temp databases/files under the same parent (for example QueryHistoryStorageTests and SQLFavoriteStorageTests), so this test can nondeterministically delete another test's live file and cause unrelated failures; make the UUID a directory component and delete only that unique directory.

Useful? React with 👍 / 👎.