feat(connections): keyboard focus and VoiceOver in the connection form and welcome screen (#1490)#1505
Merged
Merged
Conversation
…m and welcome screen (#1490)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1490 (keyboard, focus, accessibility). Connection form / welcome surface.
Keyboard focus
@FocusState+.defaultFocuson the Form), so you can type immediately; Tab follows the natural field order.onSubmit/onMoveDowncallbacks to setfocus = .connectionList).VoiceOver / Full Keyboard Access
.accessibilityAddTraits(.isSelected))..keyboardShortcut(.defaultAction)so Return activates them.Native SwiftUI focus APIs only (
@FocusState,.defaultFocus,.focused), no custom focus handling.Deferred (follow-ups)
The shared
NativeSearchField@FocusStaterefactor and theAIRulesEditorTab-forwarding are higher-risk shared/representable changes; left for separate PRs.Lint clean, style gate clean. Focus/responder behavior verified manually (not unit-testable here).