refactor: route ClickHouse partition SQL through the driver's dialect-aware quoting#1503
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 (R-007):
ClickHousePartsViewbuilt four SQL statements with hand-rolled escaping — backtick-doubling for the table identifier and single-quote-doubling for user-supplied partition values. This routes all four through the driver's dialect-awarequoteIdentifier(_:)/escapeStringLiteral(_:)instead:system.partslookup (table name used as a string literal)Risk Addressed
Correctness
PluginDriverAdapterforwardsquoteIdentifier/escapeStringLiteralto the ClickHouse plugin, which overridesquoteIdentifierto use backticks (identical to the previous output) and provides ClickHouse-specificescapeStringLiteral(more robust than the manual''). So identifiers are behavior-preserving and the user-value escaping is strictly safer.Verification
xcodebuild -scheme TablePro buildsucceeds.swiftlint --strictclean.Notes
quoteIdentifier/escapeStringLiteral(the tested units); the view's inline SQL lives in private SwiftUI methods.