fix(plugin-etcd): verify TLS client-identity type before use to avoid a crash on malformed PKCS12#1499
Merged
Merged
Conversation
… a crash on malformed PKCS12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 9 (R-009): the etcd client-certificate auth path force-cast the PKCS12 identity item (
identityRef as! SecIdentity). A PKCS12 blob whose first item is not an identity (e.g. a bare certificate) would crash the host process during the TLS auth challenge.The cast now runs only after a runtime type check folded into the existing
guard:On a type mismatch the auth challenge is cancelled gracefully (same as the adjacent failure path) instead of crashing. The remaining
as!is provably safe (type verified) and keeps a justified// swiftlint:disable:next force_cast.Risk Addressed
Verification
xcodebuild -scheme EtcdDriverPlugin buildsucceeds.Notes
swiftlint --strictwarning in this file (closure_parameter_positionon an untouched line) is out of scope.