fix(plugin-redis): throw on unexpected operation instead of crashing the host#1498
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 9 (R-009): remove a user-triggerable host crash from the Redis driver. The 7
default: fatalError("Unexpected operation in execute…Operation")branches inRedisPluginDrivernowthrow RedisPluginError(code: 0, message: …). The dispatch methods are alreadyasync throws, so an unexpected operation surfaces as a normal query error instead of crashing the whole app viafatalError.Risk Addressed
fatalErrorcould take down the host process.Verification
xcodebuild -scheme RedisDriver buildsucceeds.fatalErrorline → onethrowline each); no behavior change on the happy path.Notes
default:branches, so there is no observable behavior change.swiftlint --strictwarnings in this file (file_length1426, plus animplicit_return/vertical_whitespaceon untouched lines) are out of scope; this change doesn't add or remove lines.