fix(plugins): publish each ABI as a new plugin version, verify built kit matches label (#1380)#1399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (#1380, also the residual of #1322)
After the PluginKit ABI bump to 15 shipped in v0.44.0, users still could not install or update registry plugins (Cloudflare D1, and in fact all 10). The app correctly reported "Plugin was built for PluginKit version 14; this release needs version 15".
Root cause: the bulk re-release reused existing tags
release-all-plugins.shpaired each plugin's latest existing tag (e.g.plugin-cloudflare-d1-v1.0.22) with the new PluginKit version, and the build workflow doesgh release delete+gh release createon that same tag. Reusing one tag/asset URL for two different ABIs has two failure modes:--keep-kit-versions 2only works if each ABI is a distinct artifact at a distinct URL. Reusing the tag collapsed both ABIs onto one URL.Fix
release-all-plugins.shnow bumps the patch version (e.g.v1.0.22tov1.0.23) and dispatches the new tag, so each ABI publishes fresh binaries at a new release URL. No overwrite, no CDN staleness, and the two retained ABIs stay distinct. Also fetches tags first so the latest version is read correctly.build-plugin.ymlgains a guard: after building, it reads the bundle'sTableProPluginKitVersionand fails the job if it does not match thepluginKitVersionthe release is labeled with. A mislabeled binary can no longer reach the registry.Follow-up to unblock users
Run
./scripts/release-all-plugins.sh 15(with this fix) to publish all 10 registry plugins at new versions with genuine kit 15 binaries.No app code changes; the app already shows the correct, actionable message.