Skip to content

fix(datagrid): reflect active filters in row count and pagination#1390

Merged
datlechin merged 3 commits into
mainfrom
fix/filtered-row-count
May 22, 2026
Merged

fix(datagrid): reflect active filters in row count and pagination#1390
datlechin merged 3 commits into
mainfrom
fix/filtered-row-count

Conversation

@datlechin

Copy link
Copy Markdown
Member

What

Filtering a table now updates the row count and page count in the bottom-right to match the filtered result, instead of showing the whole-table totals.

How

  • Adds fetchFilteredRowCount(table:filters:logicMode:) to the PluginDatabaseDriver protocol, with a default implementation returning nil so a driver that can't count a filtered set falls back to the previous behavior.
  • Bridges the method through PluginDriverAdapter and DatabaseDriver; MongoDB implements it.
  • TableQueryBuilder / QueryExecutionCoordinator use the filtered count to drive the footer count and pagination when a filter is active.

PluginKit ABI

This adds a protocol method, so it bumps PluginKit ABI 14 to 15 (currentPluginKitVersion plus every bundled plugin Info.plist). ABI 14 already shipped in v0.43.2, so this is a fresh, necessary bump, not a re-bump of an unreleased version.

After this merges to main, the registry plugins need rebuilding against ABI 15:

./scripts/release-all-plugins.sh 15

Tests

  • TableQueryBuilderFilterTests covers the filtered-count query construction.

@datlechin datlechin merged commit 470ac12 into main May 22, 2026
2 of 3 checks passed
@datlechin datlechin deleted the fix/filtered-row-count branch May 22, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant