fix(datagrid): copy only visible columns in their current order (#1354)#1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354.
Problem
Copying rows from the data grid always emitted every column from the underlying result, ignoring which columns are hidden and the order the user arranged them in. The clipboard output didn't match what's on screen.
Fix
Add a small
VisibleColumnProjectionvalue type that maps a result's columns, column types, and cell values down to the visible set, in display order.indices == nilis the identity (all columns), and out-of-range indices are dropped (or treated as NULL for values), so it's safe against stale layouts.TableViewCoordinator.visibleColumnDataIndices()returns the data indices of the currently visible columns (excludes hidden columns and the row-number column) in their on-screen order. Every copy path runs through the projection:INSERT/UPDATETests
VisibleColumnProjectionTestscovers identity, reordering, hidden-column dropping, and out-of-range handling.RowOperationsManagerCopyTestsgains cases for copying with a visible-column subset.Notes
The diff also adds
.analysis/to.gitignore(local-only issue-analysis dir).