fix(plugin-dynamodb): connect with SSO sso_session profiles after aws sso login#1334
Merged
Conversation
…e with XCTest coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.aws/cli/cache(side-effect cache that only AWS CLI/SDK populates after aGetRoleCredentialsexchange).~/.aws/sso/cache/<sha1>.json(whataws sso loginactually writes) and call the SSO portalGetRoleCredentialsendpoint directly, matching how AWS SDKs resolve SSO credentials.sso_sessionand legacy SSO profiles. For modern profiles, resolvesso_start_urlandsso_regionfrom the referenced[sso-session ...]block.Fixes #1333
Test plan
sso_sessionprofile immediately afteraws sso login --profile <p>(no other AWS CLI commands needed first)sso_session,sso_start_url+sso_regiondirectly on the profile)"Run 'aws sso login --profile <p>'"message