fix: allow plain HTTP to DNS hosts for database connections (#1316)#1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1316. ClickHouse (and any HTTP-based driver) could not connect to plain-HTTP servers addressed by a DNS hostname (e.g. `xxx.example.com:8123`). App Transport Security blocked the request because only IP-addressed plain HTTP is exempt by default. Workaround was using the raw IP.
Root cause
No `NSAppTransportSecurity` key in Info.plist meant TablePro relied on Apple's defaults, which allow plain HTTP only to numeric IPs. DNS-addressed HTTP gets blocked at the URLSession layer.
Fix
Add to both macOS and iOS Info.plist:
```xml
NSAppTransportSecurity
NSAllowsArbitraryLoads
```
Standard approach for developer tools that connect to user-specified servers (TablePlus, Postman, Beekeeper, Sequel Ace, DBeaver all do the same).
Affected drivers
Native socket drivers (MySQL, PostgreSQL native protocol, Redis RESP, MongoDB wire protocol) bypass URLSession entirely and were never affected.
Test plan
Notes
The PR diff includes an unrelated `Localizable.xcstrings` cleanup (2 empty SSL string entries removed, 1 percent-format entry auto-removed). These got auto-generated by Xcode in a prior session and re-pruned. Safe to merge.