Skip to content

fix(ios): clean up Swift 6 build warnings and actor isolation in driver streaming #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
May 9, 2026
Merged

fix(ios): clean up Swift 6 build warnings and actor isolation in driver streaming #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TableProMobile/TableProMobile/Coordinators/ConnectionCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ final class ConnectionCoordinator {
// MARK: - Database / Schema Switching

func switchDatabase(to name: String) async {
guard let session, name != activeDatabase, !isSwitching else { return }
guard session != nil, name != activeDatabase, !isSwitching else { return }
isSwitching = true
defer { isSwitching = false }

Expand Down
2 changes: 1 addition & 1 deletion TableProMobile/TableProMobile/Drivers/MySQLDriver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ final class MySQLDriver: DatabaseDriver, @unchecked Sendable {
continuation.yield(.columns(columns))
var emitted = 0
while !Task.isCancelled, emitted < options.maxRows {
guard let cells = try await actor.fetchNextRow(options: options, columns: columns) else {
guard let cells = await actor.fetchNextRow(options: options, columns: columns) else {
break
}
continuation.yield(.row(Row(cells: cells)))
Expand Down
2 changes: 1 addition & 1 deletion TableProMobile/TableProMobile/Drivers/PostgreSQLDriver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ final class PostgreSQLDriver: DatabaseDriver, @unchecked Sendable {
continuation.yield(.columns(columns))
var emitted = 0
while !Task.isCancelled, emitted < options.maxRows {
guard let cells = try await actor.fetchNextRow(options: options, columns: columns) else {
guard let cells = await actor.fetchNextRow(options: options, columns: columns) else {
break
}
continuation.yield(.row(Row(cells: cells)))
Expand Down
2 changes: 1 addition & 1 deletion TableProMobile/TableProMobile/Drivers/SQLiteDriver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ final class SQLiteDriver: DatabaseDriver, @unchecked Sendable {
continuation.yield(.columns(columns))
var emitted = 0
while !Task.isCancelled, emitted < options.maxRows {
guard let cells = try await actor.fetchNextRow(options: options, columns: columns) else {
guard let cells = await actor.fetchNextRow(options: options, columns: columns) else {
break
}
continuation.yield(.row(Row(cells: cells)))
Expand Down
2 changes: 1 addition & 1 deletion TableProMobile/TableProMobile/Helpers/StreamingExporter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ actor StreamingExporter {
}

extension ExportFormat {
var fileExtension: String {
nonisolated var fileExtension: String {
switch self {
case .csv: return "csv"
case .json: return "json"
Expand Down
Loading