feat(ios): background sync, Cmd+F search focus, scene-restored search text, regex literal highlighter#1170
Merged
Merged
Conversation
… text, regex literal highlighter
… to match Substring output type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle of four small iOS polish items from the audit backlog. Each one stands alone; bundling because total LOC is small and review surfaces are independent.
D. Background sync via
BGAppRefreshTaskTableProMobileAppdeclaresstatic let backgroundSyncIdentifier = "com.TablePro.sync"and uses.backgroundTask(.appRefresh(_:))(iOS 17 SwiftUI native API) to register the sync handler.backgroundscenePhase, schedule the nextBGAppRefreshTaskRequestwithearliestBeginDate = +30min. iOS picks the actual fire time based on usage and batterysyncCoordinator.sync(...)ifAppPreferences.isCloudSyncEnabledos.Logger("com.TablePro", "BackgroundSync")Info.plistgainsUIBackgroundModes(fetch,processing) andBGTaskSchedulerPermittedIdentifiersarrayE. Cmd+F focuses search
DataBrowserViewandTableListViewadd@FocusState searchFocused: Bool, apply.searchFocused($searchFocused)on the searchable, and place a hidden Cmd+F button in.backgroundthat setssearchFocused = trueC. State restoration via
@SceneStoragesearchTextinDataBrowserViewandTableListViewswitches from@Stateto@SceneStorage("dataBrowser.searchText")and@SceneStorage("tableList.searchText")initplumbing not worth the complexity hereF. SQL syntax highlighter Regex literals
Regex<Substring>literals (#/.../#) — compile-time validated, notry!Regex<Substring>viaRegex(_:as:)instead ofNSRegularExpressionenumerateMatchesblocks consolidate into a singleapply(_ regex:color:scanText:in:on:protected:recordsProtection:)generic helper. The helper takes anyRegex<Output>so static and dynamic patterns share one code pathRange<String.Index>toNSRangeonce viaNSRange(_:in:)forNSTextStorage.addAttributeTest plan
e -l objc -- (void)[[BGTaskScheduler sharedScheduler] _simulateLaunchForTaskWithIdentifier:@"com.TablePro.sync"]) - sync handler runs but exits early because of the gate