feat(ios): alert when active connection is deleted mid-session#1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small UX win extracted from a P1 navigation refactor experiment that did not pan out (iOS 26 TabView and per-tab NavigationStack tug over the navbar surface, so the canonical Apple pattern is unusable here for now).
What lands:
ConnectedViewis removed fromappState.connectionsmid-session (for example via iCloud sync from another device), an alert appears: "This connection no longer exists. It may have been removed from another device.". Tapping OK callsdismiss(), which pops back to the connection list on iPhone or clears the detail column on iPad. Without this, the next data action would fail with a generic error and the user would not know the connection vanished.ConnectionCoordinator.navigationPathrenamed totablesPath. Only the Tables tab actually drives drill-down (TableInfo→DataBrowserView), so the new name reflects intent.navigateToPendingTable()and theNavigationStack(path:)binding are updated atomically..navigationTitle("Info")onConnectionInfoView.ConnectedView.tabTitle()already returns "Info" for the Info tab and applies it on the outer NavigationStack.Test plan
tablepro://connect/<uuid>→pendingTableNamepush still works (usestablesPath.append(table)).