fix(safe-mode): guard silent-mode confirm against rapid re-entry#1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
.silentbranches inQueryExecutionCoordinator(dispatchStatementslines 68-84 anddispatchParameterizedStatementslines 141-153) now set the sameisShowingSafeModePromptre-entry flag therequiresConfirmationbranch already used:The flag is set synchronously before the
Taskspawns, then cleared in adeferinside the closure.Why this matters
This is bug R3 from the full-app audit. Holding Cmd+Return on a connection at safe-mode level
.silentpreviously spawned multipleTasks, each awaitingconfirmDangerousQueryIfNeeded/confirmDangerousQueries. Two confirmation sheets could stack on top of each other, the user could confirm both, and the same dangerous query (e.g.DELETE FROM users WHERE 1=1) would run twice. The.requiresConfirmationbranch already had this guard, so this PR brings the.silentbranch in line.Test plan
.silent, hold Cmd+Return on a dangerous query, confirm only one confirmation sheet appears at a time.