refactor(services): inject AppServices into SyncCoordinator and add five missing singletons#1155
Merged
Conversation
…ive missing singletons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Largest single tranche so far of the
AppServicesDI completion.SyncCoordinatornow holds an injectedservices: AppServicesand reads every dependency through it instead of dialing.shareddirectly.AppServicesgains five fields:tagStorage,sshProfileStorage,licenseManager,conflictResolver,syncMetadataStorage. Theliveinitializer threads.shareddefaults through.SyncCoordinator:private init()becomesinit(services: AppServices = .live).changeTracker,metadataStorage,conflictResolverare now sourced fromservices.syncTracker / services.syncMetadataStorage / services.conflictResolverrather than from raw.shared. The instance-field shape is preserved so the 50+ in-method references (changeTracker.markDirty,metadataStorage.lastSyncDate, etc.) compile unchanged..sharedreads in method bodies converted via mechanical sed:ConnectionStorage.shared->services.connectionStorage,GroupStorage.shared->services.groupStorage,TagStorage.shared->services.tagStorage,SSHProfileStorage.shared->services.sshProfileStorage,LicenseManager.shared->services.licenseManager,AppSettingsStorage.shared->services.appSettingsStorage,AppSettingsManager.shared->services.appSettings,AppEvents.shared->services.appEvents.static let shared = SyncCoordinator()line stays unchanged (still uses the default.liveinit), so no AppDelegate or call-site change is needed.Why this matters
This is the next slice of audit findings 3.1 + arch 5.1.
SyncCoordinatorwas the second-largest concentration of raw.sharedreads after the storage trio (D3). After this PR, every singleton it touches flows through theAppServicescontainer.Test plan