refactor(services): expose six more singletons via AppServices and convert callers#1152
Merged
Merged
Conversation
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose six additional singletons via
AppServicesand convert every raw.sharedread in services-aware files:Added to
AppServices:appSettingsStorage,schemaProviderRegistry,aiKeyStorage,groupStorage,favoritesExpansionState,linkedFolderWatcher.Converted call sites (15 total):
AIChatViewModel—aiKeyStorage(1 site)FavoritesSidebarViewModel—favoritesExpansionState(3 sites)WelcomeViewModel—groupStorage,appSettingsStorage,linkedFolderWatcher(4 sites)MainContentCoordinator—schemaProviderRegistry(7 sites)WelcomeViewModel.showOnboardinghad to move from a default-value property initializer to the explicit init body so it could readservices.appSettingsStorage(default initializers can't referenceself).Why this matters
This is the second tranche of the
AppServicesDI completion (audit findings 3.1 + arch 5.1). After PR #1151 closed the gap onAppEventsuse inside the four already-converted files, this PR widens the container so every other singleton those files read can also flow throughservices. The remaining ~510 raw.sharedreads will land in domain-scoped follow-up PRs (Storage, Database, MCP, etc.).Test plan
MainContentCoordinatorretains/releases the schema provider as before (no leak, no missing schema).