fix(database): filter databaseDidConnect subscribers by payload connectionId#1148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three subscribers to
AppEvents.databaseDidConnectpreviously discarded theconnectionIdpayload that theDatabaseDidConnectstruct already carried, then ran connection-scoped work against their own connection regardless of which database actually connected. Fixed by guarding onpayload.connectionId == self.connection.id(or the equivalent local target id):MainContentCommandActions.setupDatabaseBroadcastObservers(refreshTablesper window)MainContentCoordinatorplugin-driver retry sink (setupPluginDriverper window)ERDiagramViewModel.waitForConnection(continuation resumed by any signal)Why this matters
This is bug R2 from the full-app audit, same shape as the
mainCoordinatorTeardownevent leakage that PR #1139 fixed. Reproduction:databaseDidConnectfor D fires. Without the filter, every existing window observes it and runsawait coordinator.refreshTables()against its own driver: ninefetchTables()calls instead of one.waitForConnectionresumed on any signal, then re-checkeddriver(for: connectionId)and failed with "No database connection" when the wrong DB connected first.WelcomeRouter.drainPendingSQLFilesis intentionally connection-agnostic andTerminalTabContentView.waitForSSHTunnelre-checks state inside anAsyncStreambody, so both are left unchanged.Test plan
fetchTables()(Console: search forrefreshTables/fetchTableslog lines).