fix(terminal): retry PTY write on EINTR instead of silently truncating user input#1145
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalProcessManager.write(_:)no longer treats every non-positive return fromDarwin.writeas "we're done". It distinguishes three cases:written > 0(advance),written == 0(log + abort, this should not happen on a regular fd),written < 0witherrno == EINTR(retry). Any other errno logs the byte position + errno and returns.loggeris markednonisolatedso it can be referenced from thenonisolated func write(_:)path under Swift 6 strict concurrency.LoggerisSendable, so this is correct.Why this matters
This is bug B6 from the full-app audit. A signal interrupting
write(2)mid-keystroke previously caused the inner loop to exit silently. The user's typed input was partially sent, and there was no log line to point at the cause. After this PR,EINTRretries (which is the standard POSIX contract), and any other failure leaves a Console linePTY write failed errno=<n> after <X> of <Y> bytesthat names exactly how much input made it through.The PTY here is created by
forkpty(3)withoutO_NONBLOCK, soEAGAIN/EWOULDBLOCKshould not occur. If a future change makes it non-blocking, the Console line will surface the issue and a properpoll(2)-based path can be added then.Test plan
kill -USR1 <pid>(or any signal that races) at the host process. Confirm input is not truncated and no error log is emitted.