Skip to content

Conversation

@sabbelasichon
Copy link
Collaborator

No description provided.

@sabbelasichon
Copy link
Collaborator Author

sabbelasichon commented Feb 17, 2025

@simonschaufi I would like to drop the support for version 7.4. What do you think?

@simonschaufi
Copy link
Collaborator

Tests are fine on PHP 7.4 and only fail on PHP 8.2 but why?

I would drop PHP 7.4 in a separate commit but yes, fine for me. We just have to release a new major version then.

@sabbelasichon sabbelasichon force-pushed the task/allow-consolidation-version-3 branch from 91f52a4 to 9d87d02 Compare February 17, 2025 13:22
@sabbelasichon sabbelasichon force-pushed the task/allow-consolidation-version-3 branch from 9d87d02 to 6672170 Compare February 17, 2025 13:24
@sabbelasichon
Copy link
Collaborator Author

@simonschaufi I need it right now for a project. I am going to merge it for now. If something should be changed, we can fix it later. Hope this is fine for you.

@sabbelasichon sabbelasichon merged commit 0914de2 into main Feb 17, 2025
12 checks passed
@sabbelasichon sabbelasichon deleted the task/allow-consolidation-version-3 branch February 17, 2025 13:29
@simonschaufi
Copy link
Collaborator

You could have waited a few more minutes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants