fix: 불필요한 조건 분기 제거

[AndyH0ng]

In general, to fix a condition where part of a boolean expression is always false in a given control flow path, you should either refactor the control flow so that the variable can actually vary there, or remove the dead part of the condition and document the intended behavior. Here, the component already returns early while isLoading is true, so the subsequent JSX should treat isLoading as definitively false. We should therefore simplify the CommentList prop from isLoading={isLoading || isCommentsLoading} to isLoading={isCommentsLoading}, which both resolves the CodeQL finding and more accurately reflects that only the comment‑level loading state is relevant at that point.

Concretely, in src/pages/FeedbackSlidePage.tsx, locate the CommentList JSX block inside the desktop layout (around line 97–108). Change the isLoading prop so that it no longer depends on the page‑level isLoading and depends solely on isCommentsLoading. No new imports, functions, or types are needed; this is a one‑line change that does not alter other behavior, because isLoading is already guaranteed to be false whenever that JSX is rendered.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a CodeQL warning by refining a conditional expression within the FeedbackSlidePage component. The change specifically targets the isLoading prop passed to the CommentList component, ensuring it only considers the comment-specific loading state. This improves code clarity and accuracy by removing a redundant check, as the page's overall loading state is already handled upstream, guaranteeing it to be false when the CommentList is rendered.

Highlights

• Conditional Logic Refinement: Simplified the isLoading prop for the CommentList component in FeedbackSlidePage.tsx to remove a redundant condition, addressing a CodeQL finding.
• Improved Code Accuracy: Ensured the isLoading prop accurately reflects only the comment-level loading state, as the page-level isLoading is guaranteed false at that point in the control flow.

Changelog

• src/pages/FeedbackSlidePage.tsx
  • Simplified the isLoading prop for the CommentList component from isLoading || isCommentsLoading to isCommentsLoading.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly simplifies the isLoading prop for the desktop view's CommentList. However, the fix is incomplete as a similar issue persists in the mobile view, where the comment list's loading state is broken. I've added a specific comment with a suggestion to address this and ensure consistent behavior across the application.