Draft: Space point display update -- 3dTo2d projection to Hit Association#58
Open
Draft: Space point display update -- 3dTo2d projection to Hit Association#58
Conversation
added 4 commits
February 17, 2025 12:02
…nks the space point hits across tpc views allowing for shared hover actions (color change + tool tip)
Collaborator
|
Thanks very much @Jjm321814 for your work on this! Looks very nice. My only comment is that this is effectively drawing hits, not spacepoints anymore. I'm afraid this can be a bit confusing, if the spacepoint reconstruction is not perfoerming well, there is no way to tell here because this is PR is bypassing the actual spacepoints and looking at the associated hits. I am wondering if we should make this optional? |
…e or my new addition being wrong
Collaborator
Author
|
Just repinging that this is updated to be compatible with LArSoft V10, and there are two complimentary space point displays for both hits and the 3d space point itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to DrawSpacePoint.cxx, DrawSpacePoint.h and spacepoint.py to prioritize use of space-point hit association object over space-points directly.
Main feature highlights are shown https://docs.google.com/presentation/d/13ozNkPdjZ_9fTyeltv52PiUiTGmpKgSa7UZUs5rXi50/edit#slide=id.p
Space points direct code is removed, so we would need to guarantee that the association plot is always made.
Additionally the _dataByPlane array is filled by a custom HitFromSpacePoint object, rather than a shared object like larutil::Point2D, which may limit the generalizability of code to other systems.
Occasional bugs have been observed with the shared highlighting feature that are fixed by left-clicking to adjust the view slightly.
Note the spacePoint ID displayed in the tool tip is just an index in the vector rather than a value saved to the spacePoint itself.