Conversation
added 4 commits
April 22, 2019 21:37
sumwale
approved these changes
Apr 23, 2019
Contributor
sumwale
left a comment
sumwale
left a comment
There was a problem hiding this comment.
Overall the test look good. If the overall test takes quite long to run, can you mark these as ignore for now and then later tag them so that these can be run conditionally (like mentioned here: http://www.scalatest.org/user_guide/using_the_runner#filtering). Also update the spark/store links to the latest merged revisions.
added 2 commits
April 23, 2019 14:20
Can be run conditionally and some can be converted to hydra
Contributor
|
Can one of the admins verify this patch? |
sumwale
force-pushed
the
master
branch
5 times, most recently
from
8b43301 to
2b254d9
Compare
sumwale
force-pushed
the
master
branch
5 times, most recently
from
2c254f0 to
0f2888f
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
a466d26 to
ea127bd
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
99ec79c to
c7b84fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Tests for insert/update/delete bulk ops
Considered row buffer, reduced oldEntryInterval and eviction scenarios
Patch testing
(Fill in the details about how this patch was tested)
ReleaseNotes.txt changes
(Does this change require an entry in ReleaseNotes.txt? If yes, has it been added to it?)
Other PRs
(Does this change require changes in other projects- store, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)