Skip to content

[SNAP-3176] Suppress the unnecessary log messages #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashetkar wants to merge 1 commit into
base: snappy/master
Choose a base branch
from
Open

[SNAP-3176] Suppress the unnecessary log messages #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions gemfirexd/core/src/main/java/com/pivotal/gemfirexd/internal/engine/store/RowFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,8 +1039,12 @@ public RowFormatter(final ColumnDescriptorList cdl, final String schemaName,
this.metadata = null;
this.isTableFormatter = false;
this.isPrimaryKeyFormatter = false;
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#cqi#column[] = " + ArrayUtils.toString(this.columns));
if (SanityManager.DEBUG) {
if (GemFireXDUtils.TraceRowFormatter) {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#cqi#column[] = " + ArrayUtils.toString(this.columns));
}
}
}

/**
Expand Down Expand Up @@ -1105,8 +1109,12 @@ public RowFormatter(final ColumnDescriptor[] cdl, final int size,
this.isTableFormatter = true;
}
this.isPrimaryKeyFormatter = false;
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const1#column[] = " + ArrayUtils.toString(this.columns));
if (SanityManager.DEBUG) {
if (GemFireXDUtils.TraceRowFormatter) {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const1#column[] = " + ArrayUtils.toString(this.columns));
}
}
}

/**
Expand Down Expand Up @@ -1225,8 +1233,12 @@ private RowFormatter(final ColumnDescriptorList cdl, final int size,
this.metadata = null;
this.isTableFormatter = false;
this.isPrimaryKeyFormatter = false;
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const3#column[] = " + ArrayUtils.toString(this.columns));
if (SanityManager.DEBUG) {
if (GemFireXDUtils.TraceRowFormatter) {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const3#column[] = " + ArrayUtils.toString(this.columns));
}
}
}

/**
Expand Down Expand Up @@ -1287,14 +1299,23 @@ private RowFormatter(final ColumnDescriptorList cdl, final int size,
this.metadata = getMetaData(schemaName, tableName, schemaVersion);
this.isTableFormatter = false;
this.isPrimaryKeyFormatter = isPrimaryKeyFormatter;
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const4#column[] = " + ArrayUtils.toString(this.columns));
if (SanityManager.DEBUG) {
if (GemFireXDUtils.TraceRowFormatter) {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#const4#column[] = " + ArrayUtils.toString(this.columns));
}
}
}

public void printColumnArray() {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#Recovery#column[] = " + ArrayUtils.toString(this.columns));
if (SanityManager.DEBUG) {
if (GemFireXDUtils.TraceRowFormatter) {
SanityManager.DEBUG_PRINT(GfxdConstants.TRACE_ROW_FORMATTER,
"RowFormatter#Recovery#column[] = " + ArrayUtils.toString(this.columns));
}
}
}

/**
* Get the fixed width, variable width and LOB column positions for this
* formatter.
Expand Down
6 changes: 6 additions & 0 deletions ...re/src/main/java/com/pivotal/gemfirexd/internal/iapi/services/context/ContextManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
import com.pivotal.gemfirexd.internal.iapi.error.ShutdownException;
import com.pivotal.gemfirexd.internal.iapi.error.StandardException;
import com.pivotal.gemfirexd.internal.iapi.reference.Property;
import com.pivotal.gemfirexd.internal.iapi.reference.SQLState;
import com.pivotal.gemfirexd.internal.iapi.services.i18n.LocaleFinder;
import com.pivotal.gemfirexd.internal.iapi.services.monitor.Monitor;
import com.pivotal.gemfirexd.internal.iapi.services.property.PropertyUtil;
Expand Down Expand Up @@ -742,6 +743,11 @@ private boolean reportError(Throwable t) {
this.errorStream.getLogSeverityLevel());
}
}
// SNAP-3176
if (se.getSQLState().equals(SQLState.LANG_SYNTAX_ERROR)
|| se.getSQLState().equals(SQLState.LANG_LEXICAL_ERROR)) {
return false;
}
// GemStone changes END
return (level >= logSeverityLevel) ||
(level == ExceptionSeverity.NO_APPLICABLE_SEVERITY);
Expand Down