Skip to content

Fix lora weight Loading and Unloading #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zRzRzRzRzRzRzR merged 2 commits into from
Mar 31, 2025
Merged

Fix lora weight Loading and Unloading #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
073aa4d
use unload and load again
zRzRzRzRzRzRzR Mar 30, 2025
6fde85f
use with load lora weight
zRzRzRzRzRzRzR Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cogkit/api/services/image_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,17 @@ def generate(
if model not in self._models:
raise ValueError(f"Model {model} not loaded")
width, height = list(map(int, size.split("x")))

# TODO: Refactor this to switch by LoRA endpoint API
if lora_path != self._current_lora[model]:
if lora_path is not None:
adapter_name = os.path.basename(lora_path)
_logger.info(f"Loading LORA weights from {adapter_name}")
_logger.info(
f"Loading LORA weights from {adapter_name} and unload previous weights {self._current_lora[model]}"
)
unload_lora_checkpoint(self._models[model])
load_lora_checkpoint(self._models[model], lora_path, lora_scale)
else:
_logger.info("Unloading LORA weights")
_logger.info(f"Unloading LORA weights {self._current_lora[model]}")
unload_lora_checkpoint(self._models[model])

self._current_lora[model] = lora_path
Expand Down
4 changes: 2 additions & 2 deletions src/cogkit/utils/lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ def load_lora_checkpoint(
lora_model_id_or_path: str,
lora_scale: float = 1.0,
) -> None:
pipeline.load_lora_weights(lora_model_id_or_path)
pipeline.fuse_lora(components=["transformer"], lora_scale=lora_scale)
pipeline.load_lora_weights(lora_model_id_or_path, lora_scale=lora_scale)
# pipeline.fuse_lora(components=["transformer"], lora_scale=lora_scale)


def unload_lora_checkpoint(
Expand Down