Bump Yospace dependency#107
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a4f9321 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MattiasBuelens
approved these changes
May 22, 2026
MattiasBuelens
added
enhancement
Contributor
Author
|
@MattiasBuelens, before I merge this, do you have an idea why changeset bot seems to think there are some changes to |
Contributor
|
@ceyhun-o Ah right, the Conviva connector has an optional peer dependency on the Yospace connector. Hmm. I don't think this should be a major bump for Conviva though, we should just change the peer dependency to support both majors... I'll take a look. Don't merge yet. |
MattiasBuelens
approved these changes
May 26, 2026
Contributor
|
Should be good now. Conviva connector will get a patch bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has similar changes to THEOplayer/android-connector#89 for Android to make the Yospace connector compatible with the latest version of the Yospace library. You can find their changelog here.
3 main changes are:
PlaybackModewithSessionModefor compatibility with Yospace Ad Management SDK 3.10.0+. This change brings the minimum supported Yospace Ad Management SDK version to 3.10.0.isPlaceholder()andisEncoded()type definitions since they were removed in Yospace Ad Management SDK 3.11.0. -> The alternatives for these aregetCategory()andgetStatus()according to their changelog. I haven't included these since their return types are not documented (or I couldn't find them).getStart()beingnull). The change I made basically aligns the logic to what our Android connector does.