conviva: preserve startup session across early sourcechange#104
Open
balazStefan wants to merge 1 commit intoTHEOplayer:mainfrom
Open
conviva: preserve startup session across early sourcechange#104balazStefan wants to merge 1 commit intoTHEOplayer:mainfrom
balazStefan wants to merge 1 commit intoTHEOplayer:mainfrom
Conversation
|
72ffcb0 to
f238687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conviva: avoid ending session on early startup sourcechange
Add optional startup-preservation config:
When enabled, sourcechange events during startup (play -> playing)
within the grace window no longer end the Conviva session;
source metadata is refreshed instead.
Summary
Add optional startup source-change preservation to prevent premature Conviva session endings during startup transitions, while keeping default behavior unchanged.
What changed
API / Configuration
preserveSessionOnStartupSourceChange?: boolean(defaultfalse)startupGraceMs?: number(default10000)Handler behavior
DEFAULT_STARTUP_GRACE_MS = 10_000startupAt: number | nullonPlay: marks startup start timeonPlaying: clears startup markeronSourceChange:maybeReportPlaybackEnded: clears startup markerTests
Added unit coverage via public
ConvivaConnectorAPI and event-driven scenarios:sourcechangewithin grace -> session is preservedplaying-> session ends onsourcechangeDocumentation
Unreleased