Use Uri.Builder for Uplynk connector#75
Merged
MattiasBuelens merged 7 commits intomasterfrom Mar 26, 2026
Merged
Conversation
MattiasBuelens
force-pushed
the
feature/uplynk-uri-builder
branch
from
384676d to
2ebfcfa
Compare
| private val adScheduler: UplynkAdScheduler | ||
| ) { | ||
| private val NEGATIVE_TIME = (-1).toDuration(DurationUnit.SECONDS) | ||
| private val NEGATIVE_TIME = (-1).seconds |
.../java/com/theoplayer/android/connector/uplynk/internal/UplynkSsaiDescriptionUrlExtensions.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| } else { | ||
| "" | ||
| listOf() |
Contributor
Author
There was a problem hiding this comment.
adadukin-dolby
approved these changes
Mar 25, 2026
adadukin-dolby
left a comment
adadukin-dolby
left a comment
There was a problem hiding this comment.
LGTM, only a few minor questions 👍
MattiasBuelens
force-pushed
the
feature/uplynk-uri-builder
branch
from
a9c3172 to
7b73319
Compare
MattiasBuelens
force-pushed
the
feature/uplynk-uri-builder
branch
from
7b73319 to
deab0d0
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing a bunch of (brittle) string manipulation, just use
Uri.Builder.This introduces no functional changes, it just makes the code easier to read and maintain. 😁