Skip to content

Fix enabledPlaybackActions#74

Open
tvanlaerhoven wants to merge 2 commits intomasterfrom
bugfix/mediasession/enabled-actions
Open

Fix enabledPlaybackActions#74
tvanlaerhoven wants to merge 2 commits intomasterfrom
bugfix/mediasession/enabled-actions

Conversation

@tvanlaerhoven
Copy link
Copy Markdown
Member

  • Fixed an issue where changing the set of enabledPlaybackActions would not be passed correctly to the MediaSession's PlaybackState builder.
  • Added an optional PlaybackCallback instance that allows intercepting and overwriting behavior for playback actions triggered by MediaSession.

@tvanlaerhoven tvanlaerhoven added the 🔌 connector: mediasession Affects the Media Session connector label Mar 25, 2026
@tvanlaerhoven tvanlaerhoven requested a review from OlegRyz March 25, 2026 10:19
@MattiasBuelens MattiasBuelens changed the title Bugfix/mediasession/enabled actions Fix enabledPlaybackActions Mar 26, 2026
@MattiasBuelens MattiasBuelens force-pushed the bugfix/mediasession/enabled-actions branch from a630d48 to 67555bd Compare March 26, 2026 09:05
Copy link
Copy Markdown
Contributor

@MattiasBuelens MattiasBuelens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit.


/**
* A callback for playback actions. When set, the media session will receive playback events,
* otherwise default the behavior will be executed for supported actions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* otherwise default the behavior will be executed for supported actions.
* otherwise the default behavior will be executed for supported actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔌 connector: mediasession Affects the Media Session connector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants