feat: abstract NotificationBus for swappable dispatch#70
Open
seriouscoderone wants to merge 2 commits intoTHCLab:masterfrom
Open
feat: abstract NotificationBus for swappable dispatch#70seriouscoderone wants to merge 2 commits intoTHCLab:masterfrom
seriouscoderone wants to merge 2 commits intoTHCLab:masterfrom
Conversation
…tecture Gate redb behind `storage-redb` feature flag (default ON) in keri-core and teliox so the core protocol logic can compile and run without redb. This enables future alternative storage backends (e.g., DynamoDB for serverless). Key changes: - Split EventStorage constructors: generic `new()` (no mailbox) vs `new_redb()` (RedbDatabase with mailbox) vs `new_with_mailbox()` (inject) - Make mailbox_data an Option<MailboxData> to support non-redb backends - Remove Any bound from EventValidator - Gate TelLogDatabase, teliox EscrowDatabase, and escrow module behind storage-redb feature - Genericize teliox escrow structs over K: EventDatabase for KEL storage - Add in-memory MemoryDatabase implementing all database traits for validation and testing - Move rkyv_adapter to database::rkyv_adapter (not under database::redb) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the concrete HashMap-based NotificationBus with a trait-based dispatch architecture. NotificationBus is now a Clone-able wrapper around Arc<dyn NotificationDispatch>, enabling alternative notification backends (e.g. SQS for serverless) without adding generic type parameters anywhere in the codebase. - Add NotificationDispatch trait with dispatch() and register_observer() - Extract current HashMap logic into InProcessDispatch (RwLock + OnceLock) - Add NotificationBus::from_dispatch() for custom implementations - Change register_observer from &mut self to &self across all processors - Add RwLockingError variant to keri-core Error enum Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
seriouscoderone
force-pushed
the
feat/swappable-notification-dispatch
branch
from
495e705 to
75c8a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationBuswith a trait-based dispatch architecture (Arc<dyn NotificationDispatch>)register_observermethods now take&selfinstead of&mut self(interior mutability viaRwLock)Design
NotificationBusis now aClone-able newtype wrapper. Internally it delegates toInProcessDispatch(preserving current behavior) or any customNotificationDispatchimplementation viaNotificationBus::from_dispatch().Changes
notification.rs:NotificationDispatchtrait,InProcessDispatchstruct, refactoredNotificationBuswrappererror/mod.rs: AddedRwLockingErrorvariantmod.rs/basic_processor.rs/witness_processor.rs:&mut self→&selfonregister_observermutbindingsmutfrom processor bindingsWhat does NOT change
Notifiertrait signatureNotification/JustNotificationenumsTelNotificationBus(teliox)Test plan
cargo check --all-featurescompilescargo check --package keri-core --no-default-features --features querycompiles (no redb)cargo test --all-features— all 120+ tests pass🤖 Generated with Claude Code