-
Notifications
You must be signed in to change notification settings - Fork 898
feat: Implement forum topics support #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
japananimetime
wants to merge
9
commits into
TGX-Android:main
Choose a base branch
from
japananimetime:forum-topics-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Implement forum topics support #985
japananimetime
wants to merge
9
commits into
TGX-Android:main
from
japananimetime:forum-topics-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds complete forum topics functionality: - ForumTopicsController: Main topics list with search, create, edit, delete - ForumTopicView: Custom view for topic items with icons/avatars - ForumTopicTabsController: ViewPager tabs layout for topics - Topic message filtering using GetForumTopicHistory - Per-topic unread counters, mentions, and reactions - Topic notification settings (mute/unmute) - Topic typing indicators - Topic header in chat view - Navigation integration - Forum toggle in group settings - View as chat/topics toggle - Notification separation showing "Chat > Topic" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added break statement after fall-through service message cases in ContentPreview.getContentPreview() to prevent them from falling through to the forum topic handlers. This fixes a bug where group photo changes and other service messages incorrectly showed "Topic created" in the chat list preview. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add forum layout toggle (tabs vs list) in ProfileController settings - Fix layout toggle not applying until re-entry (wasForumTabsChanged check) - Fix visual flash when entering forum tabs by using LoadingController placeholder - Add Group Info access from tabs mode for admins - Add permission checks for topic actions UI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Move search loading indicator to ClearButton in search bar (spinner where X button is) - Fix topic filter dialog icon positioning (18dp left offset instead of 68dp) - Fix settings popup ripple effect (use ?android:attr/colorControlHighlight for theme-adaptive ripple) - Remove centered ProgressComponentView in favor of search bar spinner 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fbec9a8 to
8bb1443
Compare
… forum-topics-implementation
…i, search in menu - ChatHeaderView: Add custom emoji support for forum topic icons - ForumTopicView: 3-line layout (title, sender, preview) matching chat list - ForumTopicsController: Add "View as tabs" option, fix draft updates - ForumTopicTabsController: Add "View as topics" option, move search to menu - TdlibUi: Fix viewAsTopics check for proper view mode switching - ShareController: Add forum topics support for sharing - Add topic list caching in Tdlib 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…h share UI - Fix unread badge not respecting mute state (issue TGX-Android#2) Added forumTopicNeedsMuteIcon() to properly check topic/chat mute hierarchy - Fix forum badge not updating after reading all topics (issue TGX-Android#4) Call updateForumTopicUnreadCount() after fetching fresh topic data - Fix read receipts not showing in topic messages (issue TGX-Android#9) Call manager.updateChatReadOutbox() in onForumTopicUpdated - Fix notification not opening correct topic (issue TGX-Android#14.2) Pass messageThreadId through notification intent chain - Polish share to topic UI with colored icons (issue TGX-Android#13) Show colored circle emoji and pin indicator for each topic 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix forum message link opening: load forum topic when messageTopicId is set but forumTopic is null (shows correct topic header) - Fix WebP sticker crash in ChatHeaderView: check sticker.format instead of sticker.fullType to determine ImageFile vs GifFile - Fix reaction badge icon size: use 16f to match TGChat pattern 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds complete forum topics functionality:
🤖 Generated with Claude Code
The guide below provides the flow for creating a perfect pull request to the Telegram X Repository. Before submitting your PR, ensure that it complies with the following principles.
Perfect PRs must be:
'main'branch.When fixing issues, make sure that your PR is:
When adding features, expect:
Other contributions:
PR types not mentioned above can be considered as well, provided they are rational. For example, optimizations of existing features or the app build time (for this, before/after timing is mandatory). For code refactoring, the code should be clearly improved/simplified/more convenient and is expected to be free of any edge-case bugs.
Good luck and thanks for the contribution!