Implement internal GridOverrider strategy pattern#821
Open
BrianMichell wants to merge 2 commits into
Open
Conversation
This commit introduces a new module for index strategies that replaces the monolithic GridOverrider with a set of single-responsibility IndexStrategy classes. The new structure allows for better composition and selection of strategies via the IndexStrategyRegistry, while maintaining compatibility with the existing ingestion behavior. Additionally, unit tests for the new strategies have been added to ensure functionality and correctness.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 85.30% 92.20% +6.90%
==========================================
Files 46 127 +81
Lines 2219 7548 +5329
Branches 306 448 +142
==========================================
+ Hits 1893 6960 +5067
- Misses 281 509 +228
- Partials 45 79 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.