MVP polish: TLS rule RS-TLS-001, deploy script, status badge (#153)#154
Merged
Conversation
…ge (closes #153) - detection-rules/retail/tls_downgrade_pos.kql: RS-TLS-001 detects POS endpoints negotiating TLS 1.0/1.1 or weak ciphers (RC4, DES, NULL, EXPORT) — MITRE T1557, PCI-DSS v4.0 req 4.2.1. Passes validate_kql.py. Rule count: 23 → 24 (all 24/24 pass). - scripts/deploy_all.py: one-command deployment script using Azure SDK (azure-mgmt-securityinsight) with --dry-run support. - README.md: status badge updated from In Development to Active MVP.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
F401 — ScheduledAlertRule imported but unused (removed). F541 — f-string with no placeholders on line 71 (converted to plain string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three focused improvements to bring RetailShield to professional MVP standard.
Change 1 — TLS Downgrade / Weak Cipher KQL rule
File:
detection-rules/retail/tls_downgrade_pos.kqlRule
RS-TLS-001detects POS endpoints negotiating TLS 1.0/1.1 or weak cipher suites (RC4, DES, 3DES, NULL, EXPORT, anon). Directly maps to PCI-DSS v4.0 requirement 4.2.1 — strong cryptography for cardholder data in transit.CommonSecurityLog(firewall/proxy CEF connector)validate_kql.py)Change 2 — One-command deployment script
File:
scripts/deploy_all.pyDeploys all RetailShield analytics rules to a target Sentinel workspace via
azure-mgmt-securityinsight. Supports--dry-runto preview without deploying.Change 3 — Status badge
File:
README.mdIn Development(yellow) →Active MVP(brightgreen)How to test
Closes #153