Skip to content

Comments

feat(separator): redesign with new spacing API, dotPosition and dotStyle support #30#525

Merged
airikej merged 6 commits intorcfrom
feat/30-separator-update-separator-including-storybook-stories
Feb 25, 2026
Merged

feat(separator): redesign with new spacing API, dotPosition and dotStyle support #30#525
airikej merged 6 commits intorcfrom
feat/30-separator-update-separator-including-storybook-stories

Conversation

@airikej
Copy link
Contributor

@airikej airikej commented Feb 25, 2026

BREAKING CHANGE: legacy spacing props removed, dotSize enum changed, variant values simplified

@airikej airikej linked an issue Feb 25, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

&.tedi-separator--vertical {
height: calc(100% + (var(--card-content-padding-top) + var(--card-content-padding-bottom)));
margin: calc(var(--card-content-padding-top) * -1) 0 calc(var(--card-content-padding-bottom) * -1);
&.tedi-separator--vertical {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't &--vertical work here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would result in tedi-separator--is-stretched--vertical as the &-- would apply straight to the previous selector

@airikej airikej merged commit 93e9e11 into rc Feb 25, 2026
20 checks passed
@airikej airikej deleted the feat/30-separator-update-separator-including-storybook-stories branch February 25, 2026 13:32
github-actions bot pushed a commit that referenced this pull request Feb 25, 2026
# [16.0.0-rc.18](react-16.0.0-rc.17...react-16.0.0-rc.18) (2026-02-25)

### Features

* **separator:** redesign with new spacing API, dotPosition and dotStyle support [#30](#30) ([#525](#525)) ([93e9e11](93e9e11))

### BREAKING CHANGES

* **separator:** legacy spacing props removed, dotSize enum changed, variant values simplified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Separator]: Update separator (including storybook stories)

2 participants