Skip to content

fix(modal): use correct z-index variable, default footer button align #301 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mart-sessman merged 1 commit into from
Jan 29, 2026
Merged

fix(modal): use correct z-index variable, default footer button align #301 #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tedi/components/overlay/modal/modal.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

@mixin modal-heading($size) {
.tedi-modal-header__head {

h1,
h2,
h3,
Expand All @@ -13,12 +14,18 @@
}
}

$modal-widths: (xs, sm, md, lg, xl);
$modal-widths: (
xs,
sm,
md,
lg,
xl
);

.tedi-modal {
position: fixed;
inset: 0;
z-index: 1000;
z-index: var(--z-index-modal);
display: none;

&--open {
Expand Down Expand Up @@ -95,8 +102,7 @@ $modal-widths: (xs, sm, md, lg, xl);
}

tedi-modal-header {
padding: var(--_tedi-modal-heading-padding-y)
var(--_tedi-modal-heading-padding-x);
padding: var(--_tedi-modal-heading-padding-y) var(--_tedi-modal-heading-padding-x);
border-bottom: var(--borders-01) solid var(--modal-border-inner);

.tedi-modal-header__head {
Expand All @@ -121,8 +127,8 @@ $modal-widths: (xs, sm, md, lg, xl);
tedi-modal-footer {
display: flex;
gap: var(--layout-grid-gutters-16);
padding: var(--_tedi-modal-footer-padding-y)
var(--_tedi-modal-footer-padding-x);
justify-content: flex-end;
padding: var(--_tedi-modal-footer-padding-y) var(--_tedi-modal-footer-padding-x);
border-top: var(--borders-01) solid var(--modal-border-inner);
}
}
8 changes: 4 additions & 4 deletions tedi/components/overlay/modal/modal.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export const Default: DefaultStory = {
</tedi-select>
</div>
</tedi-modal-content>
<tedi-modal-footer style="justify-content: flex-end;">
<tedi-modal-footer>
<button tedi-button variant="secondary" (click)="open = false">Cancel</button>
<button tedi-button (click)="open = false">Continue</button>
</tedi-modal-footer>
Expand Down Expand Up @@ -224,7 +224,7 @@ export const Size: StoryObj<ModalComponent> = {
</tedi-select>
</div>
</tedi-modal-content>
<tedi-modal-footer style="justify-content: flex-end;">
<tedi-modal-footer>
<button tedi-button variant="secondary" (click)="openSmall = false">Cancel</button>
<button tedi-button (click)="openSmall = false">Continue</button>
</tedi-modal-footer>
Expand All @@ -251,7 +251,7 @@ export const Size: StoryObj<ModalComponent> = {
</tedi-select>
</div>
</tedi-modal-content>
<tedi-modal-footer style="justify-content: flex-end;">
<tedi-modal-footer>
<button tedi-button variant="secondary" (click)="openDefault = false">Cancel</button>
<button tedi-button (click)="openDefault = false">Continue</button>
</tedi-modal-footer>
Expand Down Expand Up @@ -305,7 +305,7 @@ export const FooterVariants: StoryObj<ModalComponent> = {
</tedi-select>
</div>
</tedi-modal-content>
<tedi-modal-footer style="justify-content: flex-end;">
<tedi-modal-footer>
<button tedi-button variant="secondary" (click)="openDefault = false">Cancel</button>
<button tedi-button (click)="openDefault = false">Continue</button>
</tedi-modal-footer>
Expand Down