OFCP-1186 & OFCP-1183 Refactoring#14
Conversation
ddomroese
left a comment
ddomroese
left a comment
There was a problem hiding this comment.
DIe grundstruktur sieht für mich sauber und schlüssig aus. Unit tests sollten am ende des refactorings hinzugefügt werden, da das SDK keine Kernsoftware von uns ist.
| * Incoming request from the iframe to destroy the full screen ui (aka AppWidget) | ||
| */ | ||
| export const InMessageDestroyFullScreen = defineMessage<void>('destroy-full-screen', (e, sdk) => { | ||
| sdk.closeFullScreen(true); |
There was a problem hiding this comment.
ich würde hier einen anderen namen für die funktion wählen. kann gerne auch nur ein wrapper sein, der intern sdk.closeFullScreen(true); aufruft
| /** | ||
| * Outgoing message to notify the iframe that the full screen ui has been closed | ||
| */ | ||
| export const OutMessageFullScreenClosed = defineMessage<void>('full-screen-closed'); |
There was a problem hiding this comment.
muss hier evtl unterschieden werden zwischen FullScreen Closed und Destroyed?
| @@ -133,21 +127,74 @@ export class TecsafeApi { | |||
| public closeFullScreen(destroy = false): void { | |||
There was a problem hiding this comment.
closeFullScreen in zwei Funktionen trennen Close und Destroy trennen
| } | ||
|
|
||
| /** | ||
| * Hides the widget, without destroying it |
There was a problem hiding this comment.
remove duplicated typedoc annotation
|
|
||
| /** | ||
| * The base URL for the widget UIs | ||
| */ |
There was a problem hiding this comment.
add todo to exchange when needed. Kein muss
| * | ||
| * @param logLevel - The desired logging severity level. | ||
| */ | ||
| setLogLevel(logLevel: 'mute' | 'error' | 'warn' | 'info' | 'debug'): void { |
| Logger.getInstance().error( | ||
| 'Widget', | ||
| String(this.el), | ||
| 'cannot load url', |
| SingleAddToCartHandler, | ||
| } from './types/AddToCardHandler' | ||
|
|
||
| // import { parseCustomerJwt } from '@tecsafe/jwt-sdk' |
2 participants
No description provided.