Skip to content

Voice moderation overhaul#206

Closed
Rinzii wants to merge 13 commits into
TCCPP:mainfrom
Rinzii:main
Closed

Voice moderation overhaul#206
Rinzii wants to merge 13 commits into
TCCPP:mainfrom
Rinzii:main

Conversation

@Rinzii
Copy link
Copy Markdown
Contributor

@Rinzii Rinzii commented Mar 1, 2026

This PR updates voice moderation and how both mute works and how general permission updates work.

Main changes

  • Added /voice update so VC mods can manually refresh voice permissions in their current channel
  • Added role-based voice mute with duration
  • Added shared voice-update module with a reusable selector pipeline
  • Updated voice take to use the new force voice permission functionality.

How /voice update works

  • /voice update refreshes only affected users on TCCPP (those without the voice role)
  • /voice update all refreshes everyone in the channel
  • On non-TCCPP servers, all is required
  • Requires Move Members and the caller must be in a voice channel

Discussions had prior on this PR:

https://discord.com/channels/331718482485837825/801161716213219348/1477483066191515760

https://discord.com/channels/331718482485837825/801161716213219348/1480630596786065583

@jeremy-rifkin
Copy link
Copy Markdown
Member

Are there plans to use this in the imminent future? If so, it's probably be best to just include this utility in the PR where it will be used.

@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 2, 2026

Are there plans to use this in the imminent future? If so, it's probably be best to just include this utility in the PR where it will be used.

This will be used in the future but idk about imminent. It really depends on others as I only have the time to do the basic scaffolding for this, but I don't think I yet have the time to update other commands to use it. I also figured I'd make it freestanding as a utility since I imagine it would likely be used for more than just the mute command in the future.

@jeremy-rifkin
Copy link
Copy Markdown
Member

I'm very reluctant to accept a PR that adds dead code that might be used some time in the future

@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 2, 2026

I'm very reluctant to accept a PR that adds dead code that might be used some time in the future

Then I will mark this draft for now until I have the time to finish it or till someone else takes it up.

@Rinzii Rinzii marked this pull request as draft March 2, 2026 19:53
@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 7, 2026

Found some time to actually implement a duration based mute using roles to prevent screen share and voice activity. Currently though waiting on getting a proper ID for the required role so this PR is still DONOTMERGE until I have the actual role id.

@Rinzii Rinzii changed the title Add support for forcing a permissions update on a user in voice channels Add support for forcing a permissions update on a user in voice channels and mute duration Mar 7, 2026
@Rinzii Rinzii marked this pull request as ready for review March 7, 2026 22:20
@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 7, 2026

Work still needs more testing but I think the initial code is ready to be reviewed and scrutinized @jeremy-rifkin along with being open for additional discussion.

@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 9, 2026

Made some functionality changes such that we no longer attempt to update users automatically and instead make it explicit using a command.

I've also added a shared voice-update module with a reusable selector pipeline and a manual /voice update command.

Specifically on tccpp, /voice update refreshes only affected users (those without the voice role) where as /voice update all refreshes everyone and is the generic variant. On non-tccpp servers, all is required. The command uses the Move Members permission and reports succeeded, failed, and skipped counts, plus a clear error if no afk channel is configured.

Much of these changes were done due to the discussion here here on the tccpp Discord:

https://discord.com/channels/331718482485837825/801161716213219348/1480630596786065583

@Rinzii Rinzii changed the title Add support for forcing a permissions update on a user in voice channels and mute duration Voice moderation overhaul Mar 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

@Rinzii
Copy link
Copy Markdown
Contributor Author

Rinzii commented Mar 13, 2026

PR moved to a new branch and PR post located here:

#212

@Rinzii Rinzii closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants