Skip to content

task/WI-399: Expose more queue info#1238

Merged
rstijerina merged 17 commits intotask/WI-355--task/WI-361--decouple-tasfrom
task/WI-399--expose-more-queue-info
Apr 2, 2026
Merged

task/WI-399: Expose more queue info#1238
rstijerina merged 17 commits intotask/WI-355--task/WI-361--decouple-tasfrom
task/WI-399--expose-more-queue-info

Conversation

@rstijerina
Copy link
Copy Markdown
Member

@rstijerina rstijerina commented Mar 10, 2026

Overview

  • Lists all apps available to user if none specified by portal
  • Exposes more queue info, like the new schedulerOptions field for queues

Related

Changes

  • Respect archiveMode setting
  • Show queue descriptions
  • Fix schema for showTargetPath
  • Incorporate queue scheduler options into job submission
  • Show all apps to user if none specified by portal

Testing

  1. List the apps in https://cep.test/workbench/applications "My Apps", and confirm changes specified in UI
  2. Submit a job, and inspect job submission request object to confirm changes

UI

Screenshot 2026-03-10 at 3 48 24 PM Screenshot 2026-03-10 at 3 17 07 PM Screenshot 2026-03-10 at 3 16 46 PM

Notes

Copy link
Copy Markdown
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing - didn't mean to comment here yet. Will update

Copy link
Copy Markdown
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since the username piece is missing, I can't submit a job so unable to test that part.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 48.80000% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.88%. Comparing base (83696e9) to head (3ed9fdc).
⚠️ Report is 1 commits behind head on task/WI-355--task/WI-361--decouple-tas.

Files with missing lines Patch % Lines
...nt/src/components/Applications/AppForm/AppForm.jsx 63.15% 13 Missing and 1 partial ⚠️
server/portal/apps/accounts/api/views/systems.py 12.50% 14 Missing ⚠️
...rc/components/Applications/AppForm/AppFormUtils.js 41.17% 7 Missing and 3 partials ⚠️
server/portal/apps/workspace/api/views.py 41.17% 9 Missing and 1 partial ⚠️
...mmon/SystemsPushKeysModal/SystemsPushKeysModal.jsx 45.45% 6 Missing ⚠️
server/portal/apps/workspace/api/utils.py 50.00% 2 Missing and 2 partials ⚠️
server/portal/apps/auth/backends.py 57.14% 2 Missing and 1 partial ⚠️
...r/portal/apps/onboarding/steps/system_access_v3.py 33.33% 2 Missing ⚠️
server/portal/apps/accounts/managers/accounts.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                             @@
##           task/WI-355--task/WI-361--decouple-tas    #1238      +/-   ##
==========================================================================
- Coverage                                   64.01%   63.88%   -0.14%     
==========================================================================
  Files                                         450      451       +1     
  Lines                                       13401    13467      +66     
  Branches                                     2619     2653      +34     
==========================================================================
+ Hits                                         8579     8603      +24     
- Misses                                       4490     4525      +35     
- Partials                                      332      339       +7     
Flag Coverage Δ
javascript 66.87% <57.14%> (-0.17%) ⬇️
unittests 60.72% <38.18%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/components/Applications/AppForm/AppFormSchema.js 87.93% <100.00%> (-0.60%) ⬇️
...plications/AppForm/fixtures/AppForm.app.fixture.js 100.00% <ø> (ø)
...Form/fixtures/AppForm.authenticatedUser.fixture.js 100.00% <100.00%> (ø)
...ts/DataFiles/DataFilesToolbar/DataFilesToolbar.jsx 84.21% <ø> (ø)
...omponents/History/HistoryViews/JobHistoryModal.jsx 82.24% <100.00%> (+0.33%) ⬆️
client/src/redux/reducers/allocations.reducers.js 48.57% <ø> (ø)
...t/src/redux/reducers/authenticated_user.reducer.js 11.11% <ø> (ø)
client/src/redux/sagas/systems.sagas.js 0.00% <ø> (ø)
client/src/utils/getCompressParams.ts 11.11% <ø> (ø)
client/src/utils/getExtractParams.ts 14.28% <ø> (ø)
... and 11 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rstijerina and others added 11 commits March 25, 2026 10:04
* task/WI-354-CPU-Core-v4-add-username-push-keys

* add loginUser to create system credential

* handle sdsc totp prompt

* handle optional archive system in job submission

* -Fix typo, conditionally render username, remove unused imports

* Server linting

* linting

* Fix unit tests

* Linting

---------

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
@rstijerina rstijerina merged commit 5322450 into task/WI-355--task/WI-361--decouple-tas Apr 2, 2026
4 of 6 checks passed
@rstijerina rstijerina deleted the task/WI-399--expose-more-queue-info branch April 2, 2026 16:52
rstijerina added a commit that referenced this pull request Apr 2, 2026
* only fetch allocations if isTACCPortal true; no not fetch compress/extract if undefined

* list all systems available to user if no config; refactor websocket group id to allow non alphanumeric usernames from cilogon

* fix linter/test

* task/WI-399: Expose more queue info (#1238)

* respect jobAttributes "archiveMode" setting; show queue description

* fix queue description; show queue scheduleroptions; fix schema for showTargetPath

* hide queue options if hidden

* show all apps available to user if portal has no apps specified

* incorporate queue scheduler options into job submission

* Task/wi 354 cpu add username push keys (#1251)

* task/WI-354-CPU-Core-v4-add-username-push-keys

* add loginUser to create system credential

* handle sdsc totp prompt

* handle optional archive system in job submission

* -Fix typo, conditionally render username, remove unused imports

* Server linting

* linting

* Fix unit tests

* Linting

---------

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>

* fix typo

* only grab user data if is tacc portal

* fix typo

* list shared, public, and private apps

* add default state for user

* remove setupcomplete block for token view

* fix client side tests

* fix tests

* fix settings import

---------

Co-authored-by: sophia-massie <96220951+sophia-massie@users.noreply.github.com>

---------

Co-authored-by: sophia-massie <96220951+sophia-massie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants