Skip to content

task/WP-1195: Fix handling of individual files being uploaded#1236

Draft
nathanfranklin wants to merge 7 commits intomainfrom
task/WP-1195-fix-upload-model-individual-files-monitoring
Draft

task/WP-1195: Fix handling of individual files being uploaded#1236
nathanfranklin wants to merge 7 commits intomainfrom
task/WP-1195-fix-upload-model-individual-files-monitoring

Conversation

@nathanfranklin
Copy link
Copy Markdown
Member

@nathanfranklin nathanfranklin commented Mar 6, 2026

Overview

This PR fixes handling of individual files being uploaded. There was a regression when upload of files was moved to hooks and so spinners are shown on all files despite some of them being uploaded.

Related

  • [WP-1195(https://tacc-main.atlassian.net/browse/WP-1195)

Changes

Testing

  1. Upload a small file and a large >1gb file.
  2. See that the small file shows successful upload while the larger file is still being uploaded.

UI

TODO

  • check styles (i.e. placement)
  • make screenshots

@nathanfranklin nathanfranklin marked this pull request as draft March 6, 2026 22:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.01%. Comparing base (e076489) to head (7def383).

Files with missing lines Patch % Lines
client/src/hooks/datafiles/mutations/useUpload.ts 0.00% 5 Missing ⚠️
...dModalListing/DataFilesUploadModalListingTable.jsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1236   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         450      450           
  Lines       13399    13399           
  Branches     2616     2621    +5     
=======================================
  Hits         8578     8578           
  Misses       4489     4489           
  Partials      332      332           
Flag Coverage Δ
javascript 67.04% <0.00%> (ø)
unittests 60.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dModalListing/DataFilesUploadModalListingTable.jsx 27.27% <0.00%> (ø)
client/src/hooks/datafiles/mutations/useUpload.ts 46.93% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant