feat(sortableTable): auto-build filters#1178
Open
wesleyboar wants to merge 4 commits into
Open
Conversation
Tables with data-sortable-filters get a cloned fieldset before init; shared template ships via delayed assets and tup-ui snippet.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Filter labels keep abbr and other header HTML; fallback to JSON label or column name when the th is empty.
wesleyboar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Sortable tables can declare filters in
data-sortable-filtersJSON;sortableTable.jsclones a shared page template and wires search, column selects, and result counts before List.js init.Important
<i class="icon icon-search"></i>.data-aria-*in markup.Related
docs/plans/sortable-table-finish-deferred.plan.md(steps 5–6)Changes
includes/sortable_table_filter_templates.htmland include inassets_core_delayed.htmlsortableTable.jsto build filter fieldsets from template + JSON specstmp/pr-1169.htmlfor local smoke testTesting
tmp/pr-1169.htmlwith a local static server and./sortableTable.js(or module path in repo).#sortable-table-filtersonce per page.UI
Screenshots: pending upload
Notes
After merge and release, bump tup-ui snippet
sortableTable.jsjsDelivr pin from branch to the new Core-CMS tag. Step 7 (CKEditoraria-*allowlist) remains a separate PR tomain.