fix: implement onFocusReceived() for Flutter 3.44.0 compatibility#2
Open
mehrozh07 wants to merge 1 commit into
Open
fix: implement onFocusReceived() for Flutter 3.44.0 compatibility#2mehrozh07 wants to merge 1 commit into
mehrozh07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Flutter 3.44.0 added
onFocusReceived()to theTextInputClientinterface. The
QuillRawEditorStateclass (via its mixin) was missingthis implementation, causing dart2js web builds to fail with:
Error: The non-abstract class 'QuillRawEditorState' is missing
implementations for these members:
Fix
Added the missing method implementation:
Testing