chore(ci): add baseline test workflow (build + vitest + playwright)#8
Merged
Conversation
The repo had no test workflow before — only Dependabot Updates was configured, so PRs merged on local-pnpm-test trust (e.g. PR #7). Adds `.github/workflows/ci.yml`: - pnpm 11 + Node 22 (matches the local dev pin) - caches the ~50MB CCP SDE zip between runs (the build:sde script already self-invalidates after 7 days, so the static key is safe) - runs `pnpm build` (which chains build:sde + build:services + tsc -b + vite build — also our typecheck gate), then `pnpm test` (vitest), then the Playwright smoke against `pnpm preview` - uploads the Playwright report as an artifact on failure Also patches `e2e/playwright.config.ts` to fall back to Playwright's bundled Chromium when `/snap/bin/chromium` isn't present. The hardcoded snap path was synicloud-specific; GitHub Actions runners don't have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlrunning on every PR + push to main:pnpm build(which coverstsc -b+ vite build + SDE/services generation),pnpm test(vitest), and the Playwright smoke againstpnpm previewe2e/playwright.config.tsto fall back to Playwright's bundled Chromium when the synicloud-specific/snap/bin/chromiumisn't presentWhy now
Surfaced while merging PR #7 —
gh pr checks 7returned "no checks reported" because the repo had no test workflow. The only configured workflow was Dependabot Updates. PRs were merging on local-pnpm testtrust. Once this lands, the open Dependabot bumps (#1 Sentry 10, #3 TS 6, #4 plugin-react 5) become safer to merge.Design notes
pnpm buildis the typecheck gate. No separatetsc --noEmitstep; thebuildscript'stsc -bcovers it.freightdesk-sde-zip-v1).scripts/build-sde.tsalready self-invalidates the cached zip after 7 days and re-downloads from CCP. A stale cache entry just triggers one extra download.existsSync(); macOS dev boxes and Actions runners now silently fall through to Playwright's bundled Chromium. No behavior change on synicloud.Test plan
cd web && pnpm test(60/60) — unchangedcd e2e && playwright test --list— config parses, 4 tests enumerated🤖 Generated with Claude Code