Skip to content

Conversation

@ahmedtarek26
Copy link

No description provided.

@tcmitchell
Copy link
Contributor

@ahmedtarek26 thanks for the proposed update. Can you please add a description to this pull request so that we can understand what this change is and why it is being done? I have no context for this change or these files.

@ahmedtarek26
Copy link
Author

@tcmitchell I added rdf file to the rdf directory and gb file to the gb files directory then I run the test_roundtrip.py from 'src/test/python'.
I'm trying to understand the Test suite
Thanks

@jakebeal
Copy link
Contributor

jakebeal commented Aug 4, 2022

What is the purpose for the test suite? While it may be valuable for you to experiment with this information to learn about it, we don't typically add code to a community project unless it improves the project for the community.

@ahmedtarek26
Copy link
Author

I was trying to follow the steps written in the readme at the SBOLTestSuite repo and I found that I can make a pull request if the test is done.
Sorry if this pull request is useless.

@tcmitchell
Copy link
Contributor

@ahmedtarek26 thanks for taking the time to test things out.

  • Are you able to run the SBOLTestSuite tests in your local environment?
  • Were the test files you added intended to test something that is not already tested in the SBOLTestSuite?

We're happy to merge in the test files if they add additional test cases. So far, I cannot tell if they do add additional test cases, or if they were only to allow you to experiment with the unit testing.

@cjmyers
Copy link
Contributor

cjmyers commented Aug 5, 2022

SBOL3 file should be in a subdirectory under SBOL3, not RDF which is for SBOL2 RDF files.

@ahmedtarek26
Copy link
Author

@tcmitchell yeah I ran the unit test for SBOLTestSuite in my local environment. the test files you added to the directory to test it but there's a problem with the unit test I'm trying to understand it.

test_1
test_2

@ahmedtarek26
Copy link
Author

@cjmyers Ahaa , Thanks I'll change the file path.

@tcmitchell
Copy link
Contributor

@tcmitchell yeah I ran the unit test for SBOLTestSuite in my local environment. the test files you added to the directory to test it but there's a problem with the unit test I'm trying to understand it.

You should be able to run the round trip testing without the additional "in /path/to/small-molecule-etc.rdf". Try just "python -m unittest /path/to/test_round_trip.py" for example.

Please excuse typos, I am on the go.

@cjmyers cjmyers requested a review from goksel October 21, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants