Adding symbolic operand for handleLongValueOf and removing unsupported String operation#161
Open
shawshank-202 wants to merge 2 commits intoSymbolicPathFinder:sv-compfrom
Open
Adding symbolic operand for handleLongValueOf and removing unsupported String operation#161shawshank-202 wants to merge 2 commits intoSymbolicPathFinder:sv-compfrom
shawshank-202 wants to merge 2 commits intoSymbolicPathFinder:sv-compfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#108
Issue 1: required symbolic operand → crash:handleLongValueOf
Fixes: handleLongValueOf (String.valueOf(long))
Fix: added concrete fallback for long → string conversion
File:jbmc-regression/StringValueOf07.yml
Issue 2: unsupported string operation exception
incorrect double handling (pushLong instead of pushDouble)
Fix:
removed unsupported exception
corrected double handling
File:jbmc-regression/StringValueOf09.yml
Witness validated for both and meets sv-benchmarks requirements.
#108
Each commit can be used to differentiate and pinpoint fixes for better understanding