[Tests] Add test for Grid with custom repository method#624
Open
loic425 wants to merge 1 commit intoSylius:poc-new-resource-metadatafrom
Open
[Tests] Add test for Grid with custom repository method#624loic425 wants to merge 1 commit intoSylius:poc-new-resource-metadatafrom
loic425 wants to merge 1 commit intoSylius:poc-new-resource-metadatafrom
Conversation
loic425
force-pushed
the
feature/grid-with-custom-repository-method
branch
from
0a31845 to
b8d8c6c
Compare
loic425
changed the title
loic425
force-pushed
the
feature/grid-with-custom-repository-method
branch
from
b8d8c6c to
744c1e8
Compare
lchrusciel
added
the
Enhancement
lchrusciel
reviewed
Mar 17, 2023
Comment on lines
+31
to
+37
| public function createListQueryBuilder(): QueryBuilder | ||
| { | ||
| $queryBuilder = $this->createQueryBuilder('o'); | ||
| $queryBuilder->andWhere($queryBuilder->expr()->isNotNull('o.archivedAt')); | ||
|
|
||
| return $queryBuilder; | ||
| } |
Contributor
There was a problem hiding this comment.
Why did you add this code?
Member
Author
There was a problem hiding this comment.
The goal of this PR is to test if the grid configuration is applied (such as a repository method defined on the grid)
Contributor
There was a problem hiding this comment.
ok, but where is it used?
loic425
force-pushed
the
feature/grid-with-custom-repository-method
branch
from
744c1e8 to
eebcb64
Compare
loic425
force-pushed
the
poc-new-resource-metadata
branch
2 times, most recently
from
b5a7698 to
5ad1d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.