fix(render form): properly display default values#359
Open
RomulusED69 wants to merge 1 commit intoSylius:1.14from
Open
fix(render form): properly display default values#359RomulusED69 wants to merge 1 commit intoSylius:1.14from
RomulusED69 wants to merge 1 commit intoSylius:1.14from
Conversation
t-n-y
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #391
When the default value of a filter is changed, it is applied correctly, but the display is incorrect.
There is potentially a BC break since the default value must match the form data. For example, for the string type, both the value and the type need to be specified.