Skip to content

Refactor ICMP ping to avoid shell#196

Open
Syleron wants to merge 298 commits intodevfrom
ubogqs-codex/refactor-network-go-to-handle-ip-and-cidr
Open

Refactor ICMP ping to avoid shell#196
Syleron wants to merge 298 commits intodevfrom
ubogqs-codex/refactor-network-go-to-handle-ip-and-cidr

Conversation

@Syleron
Copy link
Copy Markdown
Owner

@Syleron Syleron commented May 20, 2025

Summary

  • implement ICMP ping without shell execution
  • validate IPv4 addresses before pinging
  • expand unit tests to cover CIDR and special characters
  • refine IPv4 validation logic

Testing

  • go vet ./... (fails: missing go.sum entries)
  • go test ./... (fails: missing go.sum entries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants