-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor cypress tests with commands and data tags #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Swopper050
wants to merge
21
commits into
develop
Choose a base branch
from
137-refactor-cypress-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6e894dd
Fix typescript strict flag errors (untested)
9599516
Merge branch 'develop' into 128-restructure-ui-pages-and-modals
108bf02
Remove duplicate password modal
f8b0c4b
Merge branch 'develop' into 128-restructure-ui-pages-and-modals
9d5889d
Add margin to verified e-mail
5cf7186
WIP: Started on implementing generic submit handler
da5c962
WIP: Hack field setter
24ff1b0
Add additional data setter
7fc4b2c
Cleanup
4aa1db9
WIP: Share password matcher
66f5a74
Working towards cleanup
b1ea1ab
Automatically translate messages in alert component
04518ac
Fix e2e tests
216786e
Merge request comments
23561ce
Fixed lint and added docs
Swopper050 008a2ff
Really fix lint
Swopper050 6b77f60
Use data tags and commands for cypress tests
Swopper050 887d281
Merge remote-tracking branch 'wipsel/128-restructure-ui-pages-and-mod…
Swopper050 40a4ea0
Merge commit '6b77f60' into 137-refactor-cypress-tests
Swopper050 f46056c
Refactored Cypress tests
Swopper050 025218d
Merge branch 'develop' into 137-refactor-cypress-tests
Swopper050 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||||||
| import { JSXElement } from 'solid-js' | ||||||||||
| import { JSXElement, JSX } from 'solid-js' | ||||||||||
| import { clsx } from 'clsx' | ||||||||||
| import { TranslationKey, useLocale } from '../context/LocaleProvider' | ||||||||||
|
|
||||||||||
|
|
@@ -8,7 +8,9 @@ interface AlertProps { | |||||||||
| class?: string | ||||||||||
| } | ||||||||||
|
|
||||||||||
| export function Alert(props: AlertProps): JSXElement { | ||||||||||
| export function Alert( | ||||||||||
| props: AlertProps & JSX.HTMLAttributes<HTMLDivElement> | ||||||||||
| ): JSXElement { | ||||||||||
| const { t } = useLocale() | ||||||||||
|
|
||||||||||
| const translated = () => t((props.message as TranslationKey) ?? '') | ||||||||||
|
|
@@ -25,6 +27,7 @@ export function Alert(props: AlertProps): JSXElement { | |||||||||
| <div | ||||||||||
| role="alert" | ||||||||||
| class={clsx('alert my-4', types[props.type].alert, props?.class)} | ||||||||||
| {...props} | ||||||||||
|
Comment on lines
27
to
+30
|
||||||||||
| class={clsx('alert my-4', types[props.type].alert, props?.class)} | |
| {...props} | |
| {...props} | |
| class={clsx('alert my-4', types[props.type].alert, props?.class)} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -54,13 +54,15 @@ export function TopBar(): JSXElement { | |||||
| <button | ||||||
| class="btn btn-ghost" | ||||||
| onClick={() => setOpenLoginModal(true)} | ||||||
| data-cy="open-login-modal" | ||||||
| > | ||||||
| {t('login')} | ||||||
| </button> | ||||||
|
|
||||||
| <button | ||||||
| class="btn btn-ghost" | ||||||
| onClick={() => setOpenRegisterModal(true)} | ||||||
| data-cy="open-register-modal" | ||||||
| > | ||||||
| {t('register')} | ||||||
| </button> | ||||||
|
|
@@ -108,6 +110,7 @@ export function TopBar(): JSXElement { | |||||
| setOpenLoginModal(true) | ||||||
| setSidebarOpen(false) | ||||||
| }} | ||||||
| data-cy="open-login-modal-mobile" | ||||||
| > | ||||||
| <i class="fa-solid fa-sign-in-alt mr-2" /> | ||||||
| {t('login')} | ||||||
|
|
@@ -119,6 +122,7 @@ export function TopBar(): JSXElement { | |||||
| setOpenRegisterModal(true) | ||||||
| setSidebarOpen(false) | ||||||
| }} | ||||||
| data-cy="open-login-modal-mobile" | ||||||
|
||||||
| data-cy="open-login-modal-mobile" | |
| data-cy="open-register-modal-mobile" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selector is missing a closing bracket. It should be corrected to: cy.get('[data-cy="toggle-profile-menu-dropdown"]').click();